use with statements for open()

convexengineering · Jan 5, 2024 · 56b3f52 · 56b3f52
1 parent a564516
commit 56b3f52
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/gpkit/solution_array.py b/gpkit/solution_array.py
@@ -492,7 +492,8 @@ def diff(self, other, showvars=None, *,
             if other[-4:] == ".pgz":
                 other = SolutionArray.decompress_file(other)
             else:
-                other = pickle.load(open(other, "rb"))
+                with open(other, "rb") as f:
+                    other = pickle.load(f)
         svars, ovars = self["variables"], other["variables"]
         lines = ["Solution Diff",
                  "=============",
@@ -567,8 +568,9 @@ def save(self, filename="solution.pkl",
         >>> import pickle
         >>> pickle.load(open("solution.pkl"))
         """
-        with SolSavingEnvironment(self, saveconstraints):
-            pickle.dump(self, open(filename, "wb"), **pickleargs)
+        with open(filename, "wb") as f:
+            with SolSavingEnvironment(self, saveconstraints):
+                pickle.dump(self, f, **pickleargs)
 
     def save_compressed(self, filename="solution.pgz",
                         *, saveconstraints=True, **cpickleargs):