closing some todos

gpkit/nomials/core.py

@@ -7,7 +7,6 @@
 def nomial_latex_helper(c, pos_vars, neg_vars):
     """Combines (varlatex, exponent) tuples,
     separated by positive vs negative exponent, into a single latex string."""
-    # TODO this is awkward due to sensitivity_map, which needs a refactor
     pvarstrs = ['%s^{%.2g}' % (varl, x) if "%.2g" % x != "1" else varl
                 for (varl, x) in pos_vars]
     nvarstrs = ['%s^{%.2g}' % (varl, -x) if "%.2g" % -x != "1" else varl
@@ -68,9 +67,8 @@ def str_without(self, excluded=()):
                 mstrs.append(MUL.join(cstr + varstrs))
         return " + ".join(sorted(mstrs)) + units
 
-    def latex(self, excluded=()):
+    def latex(self, excluded=()):  # TODO: add ast parsing here
         "Latex representation, parsing `excluded` just as .str_without does"
-        # TODO: add ast parsing here
         mstrs = []
         for exp, c in self.hmap.items():
             pos_vars, neg_vars = [], []

gpkit/nomials/math.py

@@ -696,12 +696,7 @@ def __init__(self, left, right):
 
     def as_hmapslt1(self, substitutions=None):
         "Returns the posys <= 1 representation of this constraint."
-        # TODO: check if it would be a monomial equality after substitutions
-        raise InvalidGPConstraint("SignomialEquality could not simplify"
-                                  " to a PosynomialInequality; try calling"
-                                  "`.localsolve` instead of `.solve` to"
-                                  " form your Model as a"
-                                  " SequentialGeometricProgram")
+        raise InvalidGPConstraint("SignomialEquality is not GP compatible.")
 
     def as_gpconstr(self, x0):
         "Returns GP approximation of an SP constraint at x0"

gpkit/units.py

@@ -59,12 +59,11 @@ def of_division(self, numerator, denominator):
 
     def of_product(self, thing1, thing2):
         "Cached unit division. Requires united inputs."
-        # TODO: qty shouldn't be necessary below
-        mul_units = qty((thing1*thing2).units)
-        key = id(mul_units)
+        key = (thing1.units, thing2.units)
         try:
             return self.multiplication_cache[key]
         except KeyError:
+            mul_units = qty((thing1*thing2).units)
             try:
                 self.multiplication_cache[key] = (None, float(mul_units))
             except DimensionalityError: