-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsonsave function for sol #1554
Conversation
Can one of the admins verify this patch? |
whitelist this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made one note, otherwise looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks feature-complete! Added notes on a couple speculative features and lint.
@Alexander-Da-Great, I merged the recent changes to master so that the unit tests would run. |
test this please |
@Alexander-Da-Great sorry for the backseat driving with |
test this please |
This branch implements json saving for solutions. This is just the implementation for solutions - excluding the diffs discussion for now. Json's produced via this method have a depth of two. It might be useful to have a hierarchical structure in the json sol that reflects the structure of the model a solution is formed from.