Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonsave function for sol #1554

Merged
merged 14 commits into from
Aug 24, 2021
Merged

jsonsave function for sol #1554

merged 14 commits into from
Aug 24, 2021

Conversation

Alexander-Da-Great
Copy link
Contributor

This branch implements json saving for solutions. This is just the implementation for solutions - excluding the diffs discussion for now. Json's produced via this method have a depth of two. It might be useful to have a hierarchical structure in the json sol that reflects the structure of the model a solution is formed from.

@acdl-jenkins
Copy link

Can one of the admins verify this patch?

@Alexander-Da-Great Alexander-Da-Great changed the title jsonsave function for sol #1552 jsonsave function for sol Aug 4, 2021
@bqpd
Copy link
Contributor

bqpd commented Aug 4, 2021

whitelist this

Copy link
Contributor

@bqpd bqpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made one note, otherwise looks great!

gpkit/solution_array.py Outdated Show resolved Hide resolved
gpkit/solution_array.py Outdated Show resolved Hide resolved
Copy link
Contributor

@bqpd bqpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks feature-complete! Added notes on a couple speculative features and lint.

gpkit/solution_array.py Outdated Show resolved Hide resolved
gpkit/solution_array.py Outdated Show resolved Hide resolved
gpkit/solution_array.py Outdated Show resolved Hide resolved
gpkit/solution_array.py Show resolved Hide resolved
gpkit/tests/t_examples.py Outdated Show resolved Hide resolved
gpkit/tests/t_examples.py Outdated Show resolved Hide resolved
@bqpd
Copy link
Contributor

bqpd commented Aug 17, 2021

@Alexander-Da-Great, I merged the recent changes to master so that the unit tests would run.

@bqpd
Copy link
Contributor

bqpd commented Aug 20, 2021

test this please

gpkit/solution_array.py Outdated Show resolved Hide resolved
@bqpd
Copy link
Contributor

bqpd commented Aug 21, 2021

@Alexander-Da-Great sorry for the backseat driving with printjson 😬 I was thinking it'd be useful to have a "canonical" json representation that various streaming APIs could use, but realized that any early API will want to be idiosyncratic with its messaging (until a good standard is found).

@bqpd
Copy link
Contributor

bqpd commented Aug 21, 2021

test this please

@Alexander-Da-Great Alexander-Da-Great merged commit 6f3b1e4 into master Aug 24, 2021
@Alexander-Da-Great Alexander-Da-Great deleted the jsonsol branch August 24, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants