Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI testing} #342

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

{CI testing} #342

wants to merge 6 commits into from

Conversation

galbramc
Copy link
Contributor

I created this pull request so I can mess with getting the CI setup without using other pull requests

@galbramc
Copy link
Contributor Author

Looks I got the CI fixed to only test the last commit, and not all commits.

@galbramc
Copy link
Contributor Author

test this please

1 similar comment
@galbramc
Copy link
Contributor Author

test this please

@galbramc
Copy link
Contributor Author

Testing with cvxopt and mosek in virtualenv's is now working.

@whoburg
Copy link
Collaborator

whoburg commented Aug 14, 2015

another intentional master push: b1943ee

@whoburg
Copy link
Collaborator

whoburg commented Aug 14, 2015

test this please

1 similar comment
@galbramc
Copy link
Contributor Author

test this please

@whoburg whoburg closed this Aug 14, 2015
@galbramc
Copy link
Contributor Author

@whoburg How do I re-open this?

@bqpd bqpd reopened this Aug 14, 2015
@bqpd
Copy link
Contributor

bqpd commented Aug 14, 2015

It is so!

@galbramc
Copy link
Contributor Author

Thank you!

@bqpd
Copy link
Contributor

bqpd commented Aug 14, 2015

Sure thing! let me know when to close it :p

@galbramc
Copy link
Contributor Author

test this please

@galbramc
Copy link
Contributor Author

@whoburg @bqpd As best as I can tell there is definitely a bug inn jenkins. I submitted a bug report here:https://issues.jenkins-ci.org/browse/JENKINS-29963?jql=project%20%3D%20JENKINS%20AND%20status%20in%20(Open%2C%20"In%20Progress"%2C%20Reopened)%20AND%20component%20%3D%20%27ghprb-plugin%27

The temporary solution is to make sure you build all pull requests twice.

The testing will also be 5 times faster once we find a way to not use .gpkit, at least in the testing.

@bqpd
Copy link
Contributor

bqpd commented Aug 15, 2015

Hmm, okay, thanks!

@bqpd bqpd closed this Aug 15, 2015
@whoburg whoburg reopened this Aug 15, 2015
@galbramc
Copy link
Contributor Author

test this please

@galbramc
Copy link
Contributor Author

Ok, I think I was able to fix it so you do not have to build twice. The way the changes were getting computed was what was messing things up. So there is still a bug, but we do not need to build twice to avoid it.

@galbramc
Copy link
Contributor Author

I forgot I need to push something to do a real test. I may have spoken too soon.

@galbramc
Copy link
Contributor Author

I spoke too soon. Keep testing twice.

@bqpd
Copy link
Contributor

bqpd commented Aug 15, 2015

Haha, will do.

Unrelatedly, it'd be great to set up some python3 test...platforms?...at some point.

@galbramc
Copy link
Contributor Author

Yes we can setup python3 testing, and pypy if you want. But until we fix #315 that will increase the testing time by a factor of 4.

@galbramc
Copy link
Contributor Author

test this please

@galbramc
Copy link
Contributor Author

I setup a python3 environment on the Linux machine, and found that there are a lot of failures in the master branch. Let me know when you are ready to have python3 testing.

@bqpd
Copy link
Contributor

bqpd commented Aug 15, 2015

Will do!

@galbramc
Copy link
Contributor Author

galbramc commented Sep 3, 2015

@bqpd We still have the bug in Jenkins where it test the previous commit rather than the current one. @whoburg Does anyone in your group know java? I think I know where the bug is in the plugin, but I'm not proficient enough in java to fix it.

@whoburg
Copy link
Collaborator

whoburg commented Sep 3, 2015

which plugin is the bug likely in? Should we contact the authors?

@galbramc
Copy link
Contributor Author

galbramc commented Sep 3, 2015

I have submitted the bug already, but not gotten any response.

https://issues.jenkins-ci.org/browse/JENKINS-29963?jql=project%20%3D%20JENKINS%20AND%20status%20in%20(Open%2C%20
"In%20Progress"%2C%20Reopened)%20AND%20component%20%3D%20%27ghprb-plugin%27

This is all people doing things on their own time. Bribery might work, and
I have found the best form of bribery is creating a pull request with the
fix.

The plugin repo is here:

https://github.com/janinko/ghprb

On Thu, 03 Sep 2015, 09:36 Warren Hoburg notifications@github.com wrote:

which plugin is the bug likely in? Should we contact the authors?


Reply to this email directly or view it on GitHub
#342 (comment).

@galbramc
Copy link
Contributor Author

galbramc commented Aug 1, 2017

test gpkit please

1 similar comment
@galbramc
Copy link
Contributor Author

galbramc commented Aug 1, 2017

test gpkit please

@galbramc
Copy link
Contributor Author

galbramc commented Aug 1, 2017

test models please

@galbramc
Copy link
Contributor Author

galbramc commented Aug 1, 2017

test gpkit please

2 similar comments
@galbramc
Copy link
Contributor Author

test gpkit please

@galbramc
Copy link
Contributor Author

test gpkit please

@bqpd bqpd changed the title Experimenting with CI testing {CI testing} Mar 21, 2018
@bqpd
Copy link
Contributor

bqpd commented Feb 5, 2020

test this please

1 similar comment
@bqpd
Copy link
Contributor

bqpd commented Feb 5, 2020

test this please

@bqpd
Copy link
Contributor

bqpd commented Feb 5, 2020

test models please

@bqpd
Copy link
Contributor

bqpd commented Jul 2, 2020

current error on windows10 cvxopt is documented here: cvxopt/cvxopt#127 (comment)

not sure what the right thing to do here is, since cvxopt just doesn't work with a pip install on the system Python right now.

@galbramc
Copy link
Contributor Author

galbramc commented Jul 2, 2020

@bpqd I installed Python 3.7 specifically due to that issue so you could test with that

@galbramc
Copy link
Contributor Author

galbramc commented Jul 2, 2020

Wait this is different. So cvxopt only works with Anaconda? Am I reading this correctly?

@bqpd
Copy link
Contributor

bqpd commented Jul 3, 2020

or if you manually add the MKL libs dir to the dll search path on the system python 😬

@galbramc
Copy link
Contributor Author

galbramc commented Jul 3, 2020

Where do I get the MKL libraries? From intel?

@galbramc
Copy link
Contributor Author

galbramc commented Jul 3, 2020

What about the proposed workaround for adding Library/bin to the PATH?

@bqpd
Copy link
Contributor

bqpd commented Jul 3, 2020

that would work for us, but not for our users, which makes me wonder if we should back to recommending Anaconda to Windows users, in which case we should use Anaconda on the test machine...

@galbramc
Copy link
Contributor Author

galbramc commented Jul 3, 2020

Ok I'll work on installing Anaconda some time next week.

@galbramc
Copy link
Contributor Author

galbramc commented Jul 6, 2020

I installed anaconda in C:\Anaconda3. Now it looks like there are legitimate unit test errors.

@bqpd
Copy link
Contributor

bqpd commented Jul 8, 2020 via email

@galbramc
Copy link
Contributor Author

galbramc commented Jul 8, 2020

You have to change the PATH at the top of the script to:

set PATH=C:\Anaconda3;C:\Anaconda3\Scripts;%PATH%

@bqpd
Copy link
Contributor

bqpd commented Jul 8, 2020

oh weird it now has a pint error...but only when doing coverage testing. Something about the hashing of our pint cache, potentially? Cannot reproduce, will see if I can with a higher python version

@galbramc
Copy link
Contributor Author

galbramc commented Jul 8, 2020

What output are you looking at?

@bqpd
Copy link
Contributor

bqpd commented Jul 8, 2020

https://acdl.mit.edu/csi/view/convex%20engineering/job/CE_gpkit_Push_unit_tests/735/buildnode=windows10x64,optimizer=cvxopt/console (and if you go back to earlier tests, you'll see it passes when I don't run coverage - only to fail bc coverage is not detected)

@galbramc
Copy link
Contributor Author

galbramc commented Jul 8, 2020

Beats me... All I can say is that coverage information is useful and you should try to get this to work.

@bqpd
Copy link
Contributor

bqpd commented Jul 8, 2020 via email

@bqpd
Copy link
Contributor

bqpd commented Jul 10, 2020

culprit was pint 0.14 compatibility issues; since that comes installed by default with anaconda it can't be uninstalled. not sure why it was only used by coverage, but seems fixed by 1571e26

@galbramc
Copy link
Contributor Author

So why are there still failing tests?

@bqpd
Copy link
Contributor

bqpd commented Jul 11, 2020 via email

@galbramc
Copy link
Contributor Author

Ok that's good. At least that got resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants