Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change to parsing format #13

Merged
merged 31 commits into from Nov 27, 2017
Merged

change to parsing format #13

merged 31 commits into from Nov 27, 2017

Conversation

mjburton11
Copy link

No description provided.

mjburton added 17 commits November 6, 2017 17:05
further edits on paper, and graph refinement
d2cb176
formatting
41d7f1f
remove some sentences
22c179c
more latex files to ignore
f5557b1
remove abstract from repo
ea741dd
change the way loading is done
15afca6
attempt at airfoil fit
fe8aa18
not deleting tau subsitution
ac35657
fix polar fit; delete process result
2edc041
refactor loading (#11)
75b3f3e 
* edit abstract for publishing (#8)

* further edits on paper, and graph refinement

* formatting

* remove some sentences

* more latex files to ignore

* remove abstract from repo

* change the way loading is done (#9)

* directly call spar loading models
adapt for parsing notation in gpmodels
6fd7ada
working with parsing
7518a9e
add bounds to solar model
9f2cb8a
move aircraft to parse format
b45b966
move motor to parsing format
09c6009
fix file call error
c59b26a
Merge branch 'master' into parseformat
1172b78
@bqpd
Copy link
Contributor

bqpd commented Nov 15, 2017 •
edited

There's a lot of new data in this PR too!

bqpd
bqpd reviewed Nov 16, 2017
View reviewed changes
solar/solar.py Outdated
V [m/s] true airspeed
rho [kg/m**3] air density
mu 1.42e-5 [N*s/m**2] viscosity
ESirr self.esirr [W*hr/m^2] solar energy
Copy link
Contributor

@bqpd bqpd Nov 16, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe consistently use either ^ or ** for exponentiation?

@mjburton11
Copy link
Author

@bqpd can you help me figure out why it's not finding my airfoil file?

@bqpd
Copy link
Contributor

bqpd commented Nov 16, 2017

hmm!

@bqpd
Copy link
Contributor

bqpd commented Nov 16, 2017

IOError: File /Users/jenkins/workspace/gpkit_ResearchModel_solar_PR/buildnode/macys_Sierra/optimizer/mosek/dai1336a.csv does not exist

You probably want it to be looking in gassolar/.../dai1336a.csv, not the root directory!

@mjburton11
Copy link
Author

This is where I have it looking dirname(abspath(__file__)) + sep + "dai1336a.csv", but can't seem to find it there.

@mjburton11 mjburton11 mentioned this pull request Nov 20, 2017
Merged
@mjburton11
Copy link
Author

@bqpd do you think I could fix this problem if installed this repo?

@bqpd
Copy link
Contributor

bqpd commented Nov 21, 2017 •
edited

you could probably reproduce this on your computer if you did that?

@mjburton11
Copy link
Author

test this please

@mjburton11
Copy link
Author

@bqpd any idea why this might have failed on reynolds?

@mjburton11
Copy link
Author

test this please

@bqpd
Copy link
Contributor

bqpd commented Nov 27, 2017

"Caused: java.io.IOException: Backing channel 'reynolds' is disconnected." from https://acdl.mit.edu/csi/job/gpkit_ResearchModel_solar_PR/buildnode=reynolds,optimizer=mosek/40/console

@bqpd
Copy link
Contributor

bqpd commented Nov 27, 2017

looks like a network issue or something

@mjburton11
Copy link
Author

oh, so if I just rerun it will probably work? Cause it work just a second ago and the only I updated was the README

@bqpd
Copy link
Contributor

bqpd commented Nov 27, 2017

yup!

@mjburton11 mjburton11 merged commit 42a2605 into master Nov 27, 2017
@mjburton11 mjburton11 deleted the parseformat branch November 27, 2017 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bqpd bqpd bqpd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjburton11 @bqpd