-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create project and feed refactor #147
Comments
Codecov Report
@@ Coverage Diff @@
## dev #41 +/- ##
========================================
+ Coverage 4.62% 4.98% +0.35%
========================================
Files 325 328 +3
Lines 12092 15419 +3327
Branches 4333 4654 +321
========================================
+ Hits 559 768 +209
- Misses 9424 12488 +3064
- Partials 2109 2163 +54
Continue to review full report at Codecov.
|
@evansiroky here's a mockup of where CreateFeedSource might work better (i.e., replacing the |
I'll refactor the CreateFeedSource containers and components so that it'll replace the FeedSourceTable. |
@landonreed did we still want to include this? |
@evansiroky, I think we should include it still, but I must admit I'm a bit afraid of what the merge conflicts will reveal. |
No more merge conflicts. Should be ready to go. |
I think I just discovered another larger issue, @evansiroky. It appears that the when updating a project, Can you confirm that this is the case? |
Confirmed and fixed. PR should be ready to be merged. |
@evansiroky, some further changes are needed:
|
These items should be addressed in the latest changes. Lmk if anything else needs fixing. |
Thanks @evansiroky, that looks good. I had a few other changes in mind that I've put in #255. Feel free to review that and merge into this branch if they look good to you. After that, I think this is good to merge. |
Reassigning to Landon as #255 has some requested changes. Also, need the requesting changes review status to change to approved. :) |
@evansiroky, could you fix up those conflicts so that I can merge? |
🎉 This issue has been resolved in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Wednesday Oct 11, 2017 at 05:24 GMT
Originally opened as catalogueglobal#41
Refactor the creation of projects and feed sources to occur on separate pages.
evansiroky included the following code: https://github.com/catalogueglobal/datatools-ui/pull/41/commits
The text was updated successfully, but these errors were encountered: