Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDBMS GTFS validation skips empty records (new lines) #280

Closed
landonreed opened this issue Apr 15, 2020 · 1 comment · Fixed by #281
Closed

RDBMS GTFS validation skips empty records (new lines) #280

landonreed opened this issue Apr 15, 2020 · 1 comment · Fixed by #281
Labels
bug released

Comments

@landonreed
Copy link
Contributor

landonreed commented Apr 15, 2020 •
edited
Loading

Observed behavior

A GTFS file that is loaded/validated in the RDBMS code path does not have errors recorded if the file contains empty records (blank new lines).

Expected behavior

An error should be logged. It may be good to simply skip importing these records into the database because they may cause unknown troubles. More investigation into expected behavior needs to be done.

Steps to reproduce the problem

Load/validate via CLI a GTFS file that has blank lines in one of the tables (e.g.
santarosa.zip).

Notes on configuration and files required to reproduce the issue

N/A
@landonreed landonreed added the bug label Apr 15, 2020
landonreed added a commit that referenced this issue Apr 20, 2020
@landonreed
fix(Table): do not skip empty lines in csv reader
130ff68 
fix #280
@landonreed landonreed mentioned this issue Apr 20, 2020
Merged
5 tasks
landonreed added a commit to ibi-group/datatools-server that referenced this issue Apr 20, 2020
@landonreed
build(deps): bump gtfs-lib to 6.0.1 for empty line validation
1a4ec93 
re conveyal/gtfs-lib#280
@landonreed landonreed mentioned this issue Apr 20, 2020
Merged
5 tasks
@landonreed
Copy link
Contributor Author

🎉 This issue has been resolved in version 6.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

landonreed added a commit to ibi-group/datatools-server that referenced this issue Jul 15, 2020
@landonreed
build(deps): bump gtfs-lib to 6.0.1 for empty line validation
16c6aee 
re conveyal/gtfs-lib#280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not skip empty lines in csv reader conveyal/gtfs-lib
1 participant
@landonreed