Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger patch/micro release with README tweak #267

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Trigger patch/micro release with README tweak #267

merged 1 commit into from
Jun 10, 2019

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented Jun 7, 2019

Automated dependency bumps for security in #264, #265, and #266 will not trigger a semver release.
I'm using this wording tweak in README to handle this.

Automated ependency bumps for security in #264, #265, and #266 will not trigger a semver release.
I'm using this wording tweak in README to handle this.
@codecov-io
Copy link

codecov-io commented Jun 7, 2019

Codecov Report

Merging #267 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #267   +/-   ##
=======================================
  Coverage   64.42%   64.42%           
=======================================
  Files          19       19           
  Lines         447      447           
  Branches       79       79           
=======================================
  Hits          288      288           
  Misses        136      136           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f20040...a3b933a. Read the comment docs.

Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably won't work as intended if you're hoping to create a release on the 4.x branch as version 5 of mastarm has already been released. We may want to look into using semantic-release v16 which is able to handle multiple release branches or just perform a manual 4.x release for now.

@evansiroky evansiroky assigned landonreed and unassigned evansiroky Jun 7, 2019
@landonreed
Copy link
Contributor Author

@evansiroky, do you anticipate issues with bumping mastarm in datatools-ui and other projects to v5? If not, let's just merge these into a new patch release on v5 and bump our other UI projects.

@trevorgerhardt
Copy link
Member

FYI: We do not intend to continue using mastarm for analysis-ui in the future. Feel free to make changes without my review 👌

@landonreed landonreed removed the request for review from trevorgerhardt June 10, 2019 14:44
@landonreed
Copy link
Contributor Author

BTW, I just updated otp-react-redux to mastarm 5 and didn't have any issues: https://github.com/opentripplanner/otp-react-redux/tree/mastarm-5

I say we merge this in and just update our UI projects to mastarm 5.0.1/node 12.

@trevorgerhardt
Copy link
Member

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants