Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransportNetworkCache swallows exceptions silently #301

Closed
abyrd opened this issue Jul 11, 2017 · 1 comment
Closed

TransportNetworkCache swallows exceptions silently #301

abyrd opened this issue Jul 11, 2017 · 1 comment
Assignees
@abyrd
Labels
bug

Comments

@abyrd
Copy link
Member

abyrd commented Jul 11, 2017

When loading a TransportNetwork into the TransportNetworkCache, if an exception occurs and propagates all the way up to the cache, it is silently consumed and the cache returns null. This hides minor problems and prevents them from being logged when they are encountered on a remote server.
@abyrd abyrd self-assigned this Jul 11, 2017
@abyrd abyrd added the bug label Jul 11, 2017
@abyrd abyrd closed this as completed in 2695170 Jul 11, 2017
@abyrd abyrd mentioned this issue Jul 11, 2017
Closed
@mattwigway
Copy link
Contributor

mattwigway commented Jul 11, 2017 •
edited

Ah, I also fixed this in my branch merge-request-types.

abyrd added a commit that referenced this issue May 4, 2019
@abyrd
fix(TransportNetworkCache): fail hard on missing scenarios
e69c84a 
addresses #514
other related tickets are #301 #424 #483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abyrd abyrd

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abyrd @mattwigway