Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate large GTFS geographic extents #780

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Tolerate large GTFS geographic extents #780

merged 2 commits into from
Jan 20, 2022

Conversation

abyrd
Copy link
Member

@abyrd abyrd commented Jan 19, 2022

This is an initial response to #779. Certain exceptions are translated to GtfsErrors to prevent them from making the feed unusable.

@trevorgerhardt
Copy link
Member

checkWgsEnvelopeSize is also used for OSM extents. Should we continue to throw an error for OSM?

@abyrd
Copy link
Member Author

abyrd commented Jan 20, 2022

checkWgsEnvelopeSize is also used for OSM extents. Should we continue to throw an error for OSM?

Yes, the strict extents checking was originally intended for OSM data since that automatically determines the default linking grid. For example, upload OSM containing islands on either side of 180 degrees longitude, and it thinks you want a grid spanning the whole Earth.

The same checks were then reused for GTFS, where the problem isn't as important because GTFS stops outside the OSM area are just not linked to the road. They cause only a marginal performance hit and it can be more trouble than it's worth to manually modify the GTFS.

@abyrd abyrd marked this pull request as ready for review January 20, 2022 05:30
trevorgerhardt
trevorgerhardt previously approved these changes Jan 20, 2022
@abyrd abyrd merged commit f71de52 into dev Jan 20, 2022
@abyrd abyrd deleted the tolerate-gtfs-extents branch January 20, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants