Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set linking distance for non-scenario egress tables #787

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Set linking distance for non-scenario egress tables #787

merged 2 commits into from
Mar 28, 2022

Conversation

abyrd
Copy link
Member

@abyrd abyrd commented Feb 1, 2022

This should fix issue #781. Looks good so far in tests.

@abyrd
move linking distance selection out of conditional
9f581c0 
also invert condition, update comments and assertion
addresses #781
@abyrd abyrd marked this pull request as ready for review March 22, 2022 16:10
@abyrd abyrd enabled auto-merge March 22, 2022 16:53
trevorgerhardt
trevorgerhardt approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@trevorgerhardt trevorgerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isochrone with bike egress turned on increases substantially with this change. From the comments, this PRs appears to have done what was intended 👍

@abyrd abyrd merged commit 78dc933 into dev Mar 28, 2022
@abyrd abyrd deleted the issue-781 branch March 28, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansoncfit ansoncfit Awaiting requested review from ansoncfit

@trevorgerhardt trevorgerhardt Awaiting requested review from trevorgerhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abyrd @trevorgerhardt