Prevent ArrayIndexOutOfBoundsException when recording TemporalDensityResult #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abyrd
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
It's clear from the updated Javadoc and the constant array dimension in line 48/49 where the error came from, and that the patch will keep m within array index bounds. As mentioned on the call, we must not have generated a travel time of exactly 120 minutes in testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided our temporal density results have 120 columns (0 to 119). In the
TemporalDensityResultconstructor, the third dimension is 120:this.opportunitiesPerMinute = new double[destinationPointSets.length][nPercentiles][120]When recording results, opportunities should only be recorded if they are less than 120 minutes away, as proposed in this PR.