Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transitive crashes for routes without short name #55

Closed
landonreed opened this issue Nov 4, 2020 · 1 comment · Fixed by #56
Closed

transitive crashes for routes without short name #55

landonreed opened this issue Nov 4, 2020 · 1 comment · Fixed by #56

Comments

@landonreed
Copy link
Contributor

This has been somewhat squirrelly (see #24, #51), but transitive is still crashing on missing short names.

Steps to reliably reproduce:
Either visit this url OR (locally):

  1. use mass511 config branch
  2. ./run.js mass511
  3. Visit http://localhost:8080/#/?ui_activeSearch=j2xhm9zq9&ui_activeItinerary=0&fromPlace=Natick%2C%20MA%2C%20USA%3A%3A42.283990000000074%2C-71.34617999999995&toPlace=Boston%2C%20MA%2C%20USA%3A%3A42.35866000000004%2C-71.05673999999993&date=2020-11-03&time=16%3A13&arriveBy=false&mode=WALK%2CBUS%2CRAIL%2CSUBWAY%2CTRAM%2CFERRY&showIntermediateStops=true&maxWalkDistance=1207&optimize=QUICK&walkSpeed=1.34&ignoreRealtimeUpdates=true&companies=&bannedRoutes=&numItineraries=3&otherThanPreferredRoutesPenalty=900&preferredRoutes=
  4. transitive throws the following exception:
Uncaught TypeError: this.parent.getName is not a function
    at t.value (label.js:36)
    at t.value (label.js:30)
    at t.value (segmentlabel.js:70)
    at default-renderer.js:117
    at e.exports (_arrayEach.js:15)
    at e.exports (forEach.js:37)
    at t.value (default-renderer.js:116)
    at e.value (transitive.js:162)
    at f.updateBoundsAndRender (index.js:118)
    at f.onDrawLayer (index.js:133)

This appears to be an npe when this.parent.getName is called here:

initText () {
return this.parent.getName()
}

@landonreed
Copy link
Contributor Author

🎉 This issue has been resolved in version 0.13.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant