Refactor dockerfile and entrypoint script #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use static version instead of latest - Perform actions in a single layer
- Run jq with compact output - Fail if cannot call dispatch function
NotNils
reviewed
Jan 28, 2022
| @@ -82,6 +82,11 @@ validate_args() { | |||
| fi | |||
| } | |||
|
|
|||
| lets_wait() { | |||
| echo "Sleeping for ${wait_interval} seconds" | |||
| sleep $wait_interval | |||
There was a problem hiding this comment.
This needs a fix I think. Compare it to line 127
There was a problem hiding this comment.
what exactly does need to be changed? code is in two sections, one has quotes, other does not, both work the same.
duhow
added a commit
to duhow/trigger-workflow-and-wait
that referenced
this pull request
Mar 9, 2022
Re-add changes done in convictional#41
neilmayhew
added a commit
to neilmayhew/trigger-workflow-and-wait
that referenced
this pull request
Mar 14, 2022
* Combine layers in Docker image * Use -c with jq when formatting client_payloads * Refactor waiting into a common function Originally authored by @duhow (David Girón <contacto@duhowpi.net>)
neilmayhew
added a commit
to neilmayhew/trigger-workflow-and-wait
that referenced
this pull request
Mar 14, 2022
* Combine layers in Docker image * Use -c with jq when formatting client_payloads * Refactor waiting into a common function Originally authored by @duhow (David Girón <contacto@duhowpi.net>)
neilmayhew
added a commit
to neilmayhew/trigger-workflow-and-wait
that referenced
this pull request
Mar 14, 2022
* Combine layers in Docker image * Use -c with jq when formatting client_payloads * Refactor waiting into a common function Originally authored by @duhow (David Girón <contacto@duhowpi.net>)
neilmayhew
added a commit
to neilmayhew/trigger-workflow-and-wait
that referenced
this pull request
Mar 14, 2022
* Combine layers in Docker image * Use -c with jq when formatting client_payloads * Refactor waiting into a common function Originally authored by @duhow (David Girón <contacto@duhowpi.net>)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Dockerfile:
For entrypoint: