Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict videos to a certain size in the chat window #801

Closed
Mar0xy opened this issue Oct 30, 2022 · 6 comments
Closed

Restrict videos to a certain size in the chat window #801

Mar0xy opened this issue Oct 30, 2022 · 6 comments
Assignees
Milestone

Comments

@Mar0xy
Copy link

Mar0xy commented Oct 30, 2022

Is your feature request related to a problem? Please describe.
It is really messy that when someone or you yourself upload a video that it tends to take a lot of space in the chat window so that you have to scroll up a lot just to get back to prior messages or down to get back to recent ones.

Describe the solution you'd like
It would be clever to restrict the maximum size of the video element so that it doesn't just take up a lot of space inside the chat window

@jhthorsen jhthorsen added this to the 7.xx milestone Oct 30, 2022
@jhthorsen
Copy link
Collaborator

Do you suggest a max-width and/or max-height? I wonder what the "magical" number would be... Maybe max 40% of the chat height? Do you have a screenshot to make the issue clearer visually?

@Mar0xy
Copy link
Author

Mar0xy commented Oct 31, 2022

Do you suggest a max-width and/or max-height?

I think both would be good to have in some way. as seen in the GIF

Peek 2022-10-31 01-04

@jhthorsen
Copy link
Collaborator

Wow! Thanks for the gif. It makes it all much clearer 😮

I wonder how hard it will be to set max-height... Don't have time to look at it at the moment, but this will get fixed one way or another.

@Mar0xy
Copy link
Author

Mar0xy commented Oct 31, 2022

Yeah, I have realized this issue pretty early when I installed Convos and was surprised no one else showed this as it basically happens with every video.

@jhthorsen
Copy link
Collaborator

The change will be part of the next release - Hopefully within 24 hours.

@jhthorsen jhthorsen self-assigned this Oct 31, 2022
@jhthorsen
Copy link
Collaborator

Yeah, I have realized this issue pretty early when I installed Convos and was surprised no one else showed this as it basically happens with every video.

I think the reason is that a lot of videos are horizontal and not vertically. At least I've never seen a vertical video in Convos, or I would've noticed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants