Preparation for k8s 1.22 update #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heronrs
commented
Oct 21, 2022
| @@ -268,7 +268,7 @@ resource "kubernetes_service" "api" { | |||
| } | |||
| } | |||
|
|
|||
| resource "kubernetes_ingress" "api" { | |||
| resource "kubernetes_ingress_v1" "api" { | |||
There was a problem hiding this comment.
If we do this type of change while also updating to k8s 1.22, terraform will fail to delete the previous ingress resource bc the resource spec was removed in 1.22
yuriadams
approved these changes
Oct 24, 2022
nightfury1204
approved these changes
Oct 24, 2022
heronrs
added a commit
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
This will update some k8s deprecated ingress resources we use in terraform and also update the metrics server deployment.
I also made some tweaks on the nginx deployment as the current config has some known bugs.
Add screenshot or video (optional)
** Any screenshot or video capture using the feature **
Does it has a breaking change?
Nope
How to use/test it?
The current e2e tests should cover it, as it communicated with the API server.
Checklist