First stab at distinct health check ports #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beastawakens
requested review from
nightfury1204
and removed request for
nightfury1204
|
@beastawakens thanks for the pr. We will look into it |
Comment on lines
+154
to
+162
| if s.Health.Port.Port == 0 && s.Port.Port > 0 { | ||
| m.Services[i].Health.Port.Port = s.Port.Port | ||
| if s.Port.Scheme != "" { | ||
| m.Services[i].Health.Port.Scheme = s.Port.Scheme | ||
| } else { | ||
| m.Services[i].Health.Port.Scheme = "http" | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
What will happen if health port is defined but health scheme is not defined?
There was a problem hiding this comment.
As the code shows, if you don't define the scheme, it will default to http.
There was a problem hiding this comment.
I am asking when health port is defined case. i can see in the code if health port defined the it will not execute the scheme condition in here
There was a problem hiding this comment.
Oh, I see, sorry I misunderstood 😆 Yeah, I may have missed that... let me update!
There was a problem hiding this comment.
@nightfury1204 added default now, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
Allows to define a health check and liveness port separate from the main service port. This is useful in situations where the service is listening on one port which you want to expose via a load balancer, so you define that port under the
portslist, but this would mean the health/liveness check would not run as it relies on the port being defined underport.It would also allow for a service that exposes multiple ports but you would wish to keep the health/liveness port not exposed beyond the rack, so you define that separately.
Does it has a breaking change?
I don't believe so. The manifest is setup to default the port to the service port if it is not defined already.
How to use/test it?
Specify a port under the the health/liveness sections of your convox.yml
Checklist