Support custom dockerignore files #753
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
Docker added support for custom .dockerignore files based on the Dockerfile name here. As Convox tars up the dir to upload the build before analysing the Dockerfile name, we can support a custom ignorefile with a flag on the build CLI simply like this.
Does it has a breaking change?
No, it will default to the standard .dockerignore filename if not specfied.
How to use/test it?
Create a different .dockerignore file, pass this on a build with the
--ignoreflag and see if it is respected in the way the directory is tar'd up to upload for the build.Checklist