Merge pull request #24 from convox/app-name-validation

validate app names. fixes convox/kernel#110
convox · Sep 16, 2015 · be65f63 · be65f63
2 parents cc7253c + a69a990
commit be65f63
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/api/models/app.go b/api/models/app.go
@@ -73,12 +73,13 @@ func GetApp(name string) (*App, error) {
 	return app, nil
 }
 
+var regexValidAppName = regexp.MustCompile(`\A[a-z0-9_]{4,30}\z`)
+
 func (a *App) Create() error {
 	helpers.SendMixpanelEvent("kernel-app-create-start", "")
 
-	if len(a.Name) < 2 {
-		helpers.SendMixpanelEvent("kernel-app-create-error", "")
-		return fmt.Errorf("invalid app name")
+	if !regexValidAppName.MatchString(a.Name) {
+		return fmt.Errorf("app name must be [a-z0-9_] and between 4 and 30 characters")
 	}
 
 	formation, err := a.Formation()