Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for max cluster size #1036

Closed
wants to merge 1 commit into from
Closed

Conversation

beedub
Copy link
Contributor

@beedub beedub commented Aug 11, 2016

I tried to regenerate the templates as well, but got:

$ make -C api templates ; make fixtures
go-bindata -nometadata -pkg=models -prefix=models -o=models/templates.go models/templates/...
go-bindata -nometadata -pkg=aws -prefix=provider/aws -o=provider/aws/templates.go provider/aws/templates/...
go install github.com/convox/rack/api/cmd/fixture
rm api/models/fixtures/*.json
make -C api/models/fixtures
env AWS_REGION=us-test-2 PROVIDER=test RACK=convox-test fixture balancer_labels.yml > balancer_labels.json
env AWS_REGION=us-test-2 PROVIDER=test RACK=convox-test fixture command_exec_form.yml > command_exec_form.json
env AWS_REGION=us-test-2 PROVIDER=test RACK=convox-test fixture command_string_form.yml > command_string_form.json
env AWS_REGION=us-test-2 PROVIDER=test RACK=convox-test fixture complex_environment.yml > complex_environment.json
env AWS_REGION=us-test-2 PROVIDER=test RACK=convox-test fixture custom_health.yml > custom_health.json
env AWS_REGION=us-test-2 PROVIDER=test RACK=convox-test fixture environment_map.yml > environment_map.json
env AWS_REGION=us-test-2 PROVIDER=test RACK=convox-test fixture multi_balancer.yml > multi_balancer.json
env AWS_REGION=us-test-2 PROVIDER=test RACK=convox-test fixture web_external_internal.yml > web_external_internal.json
env AWS_REGION=us-test-2 PROVIDER=test RACK=convox-test fixture web_postgis.yml > web_postgis.json
ERROR: web links to service: postgres which does not expose any ports
make[1]: *** [web_postgis.json] Error 1
make: *** [fixtures] Error 2

@codecov-io
Copy link

codecov-io commented Aug 11, 2016

Current coverage is 16.67% (diff: 100%)

Merging #1036 into master will not change coverage

@@             master      #1036   diff @@
==========================================
  Files           137        137          
  Lines         11595      11595          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1933       1933          
  Misses         9539       9539          
  Partials        123        123          

Powered by Codecov. Last update c241af9...26e9bfb

@@ -1020,7 +1025,7 @@
"HealthCheckType": "EC2",
"HealthCheckGracePeriod": "120",
"MinSize" : "1",
"MaxSize" : "100",
"MaxSize" : { "Ref" : "MaxClusterSize" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to not just set this to a really big number in the first place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my first thought, but I thought people might want to have a max safeguard and not accidentally start 1000 servers? Either way is fine for me for now

@ddollar
Copy link
Contributor

ddollar commented Aug 11, 2016

I think we can let EC2 limit take care of the safeguards for now and just make this a really big number.

@beedub
Copy link
Contributor Author

beedub commented Aug 11, 2016

set statically to 1000 @ddollar

@ddollar ddollar added the merge label Aug 12, 2016
@ddollar ddollar modified the milestone: 20160812 Aug 12, 2016
ddollar added a commit that referenced this pull request Aug 12, 2016
@ddollar ddollar mentioned this pull request Aug 12, 2016
13 tasks
ddollar added a commit that referenced this pull request Aug 12, 2016
ddollar added a commit that referenced this pull request Aug 12, 2016
ddollar added a commit that referenced this pull request Aug 12, 2016
ddollar added a commit that referenced this pull request Aug 12, 2016
ddollar added a commit that referenced this pull request Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants