New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting for max cluster size #1036
Conversation
Current coverage is 16.67% (diff: 100%)@@ master #1036 diff @@
==========================================
Files 137 137
Lines 11595 11595
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1933 1933
Misses 9539 9539
Partials 123 123
|
@@ -1020,7 +1025,7 @@ | |||
"HealthCheckType": "EC2", | |||
"HealthCheckGracePeriod": "120", | |||
"MinSize" : "1", | |||
"MaxSize" : "100", | |||
"MaxSize" : { "Ref" : "MaxClusterSize" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason to not just set this to a really big number in the first place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my first thought, but I thought people might want to have a max safeguard and not accidentally start 1000 servers? Either way is fine for me for now
I think we can let EC2 limit take care of the safeguards for now and just make this a really big number. |
set statically to 1000 @ddollar |
I tried to regenerate the templates as well, but got: