Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctor Database, Reloading and Command Checks #1334

Merged
merged 7 commits into from Oct 26, 2016
Merged

Conversation

nzoschke
Copy link
Contributor

@nzoschke nzoschke commented Oct 21, 2016

  • Renames Doctor "resource" checks to sync with guide
  • Fixes Doctor docs links
  • Adds Database, Reloading and Command checks
### Setup
[✓] Convox CLI version    
[✓] Docker running    
[✓] Docker up to date    
[✓] Docker pull hello-world works    


### Build: Image
[✓] Dockerfiles found    
[!] .git in .dockerignore    
It looks like you don't have a .dockerignore file
https://docs.docker.com/engine/reference/builder/#/dockerignore-file
[✓] Large files in .dockerignore    
[✓] Image builds successfully    


### Build: Service
[✓] docker-compose.yml found    
[✓] docker-compose.yml valid    
[✓] docker-compose.yml version 2    
[✓] Dockerfiles found    
[✓] Service web is valid    
[✓] Service worker is valid    


### Build: Environment
[!] .env found    
A .env file is recommended to manage development configuration
https://convox.com/guide/environment/


### Run: Balancer
[✓] App exposes ports    


### Run: Database
[!] App defines Database    
This app does not define any Databases
http://convox.com/guide/databases/


### Run: Link
[!] App defines Links    
This app does not define any Links
http://convox.com/guide/links/
[✓] Service web environment expects     
[✓] Service worker environment expects     


### Development: Reloading
[✓] Service worker reloading: ./, package.json    
[✓] Service web reloading: ./, package.json    


### Development: Commands
[✓] Service web runs `sh`    
[✓] Service worker runs `sh`    


Success: Your app looks ready for development. 
Run it with `convox start`.

@codecov-io
Copy link

codecov-io commented Oct 21, 2016

Current coverage is 29.29% (diff: 3.06%)

Merging #1334 into master will increase coverage by 0.21%

@@             master      #1334   diff @@
==========================================
  Files           136        136          
  Lines         12718      12904   +186   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3698       3780    +82   
- Misses         8629       8723    +94   
- Partials        391        401    +10   

Powered by Codecov. Last update 1bee7e8...f6c627b

@ddollar ddollar added the merge label Oct 23, 2016
@ddollar ddollar modified the milestone: 20161023 Oct 23, 2016
ddollar added a commit that referenced this pull request Oct 23, 2016
@ddollar ddollar mentioned this pull request Oct 23, 2016
18 tasks
@ddollar ddollar removed the merge label Oct 23, 2016
@ddollar ddollar removed this from the 20161023 milestone Oct 23, 2016
@nzoschke nzoschke changed the title Database Doctor Doctor Database, Reloading and Command Checks Oct 24, 2016
@ddollar ddollar added the merge label Oct 24, 2016
@ddollar ddollar added this to the 20161024 milestone Oct 24, 2016
ddollar added a commit that referenced this pull request Oct 24, 2016
@ddollar ddollar mentioned this pull request Oct 24, 2016
18 tasks
ddollar added a commit that referenced this pull request Oct 24, 2016
@nzoschke
Copy link
Contributor Author

Doctor: Reloading check

@nzoschke nzoschke merged commit 2f0494f into master Oct 26, 2016
@nzoschke nzoschke deleted the doctor-database branch October 26, 2016 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants