Use .NoError() instead of .Nil() for error checking in tests #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror prints the error instead of just saying it should’ve been nil
Current coverage is 29.73% (diff: 100%)@@ master #1566 diff @@
==========================================
Files 138 138
Lines 13212 13212
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 3929 3929
Misses 8863 8863
Partials 420 420
|
ddollar
approved these changes
Jan 17, 2017
ddollar
added a commit
that referenced
this pull request
Jan 18, 2017
ddollar
added a commit
that referenced
this pull request
Jan 18, 2017
MiguelMoll
added a commit
that referenced
this pull request
Jan 18, 2017
SonOfBytes
pushed a commit
to SonOfBytes/rack
that referenced
this pull request
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while working on my other PR.
.NoError()is the more correct function, as it actually prints the error instead of just saying it should've beennil, with an ugly pointer address to a string.I made this change with a regex find/replace. It was rather specific, so there shouldn't have been any lines changed by mistake (and I didn't notice any when looking at the diff), but it's possible I missed some lines that should've been changed.