Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] 20170208 #1822

Merged
merged 34 commits into from Feb 8, 2017
Merged

[RELEASE] 20170208 #1822

merged 34 commits into from Feb 8, 2017

Conversation

MiguelMoll
Copy link
Contributor

@MiguelMoll MiguelMoll commented Feb 8, 2017

Pull Requests

Milestone Release

  • Release branch
  • Pass CI
  • Code review
  • Merge into master
  • Close milestone
  • Release master
  • Record release number: 20170209003424
  • Pass CI
  • Update demo
  • Deploy demo/httpd
  • Deploy demo/rails
  • Update staging
  • Deploy staging/site-staging
  • Deploy staging/console-staging
  • Update release notes
  • Documentation review
  • Publish release
  • Release CLI

AJ Bowen and others added 30 commits February 7, 2017 09:58
Usage of SendEvent increased to track build success and errors. Also
adjusted Segment events accordingly.
@@ -53,6 +53,7 @@ func ListApps() (Apps, error) {
return apps, nil
}

// Deprecated: Provider.AppGet() should be used instead

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment on exported function GetApp should be of the form "GetApp ..."

@MiguelMoll
Copy link
Contributor Author

20170208

@codecov
Copy link

codecov bot commented Feb 8, 2017

Codecov Report

Merging #1822 into master will decrease coverage by -0.33%.

@@            Coverage Diff             @@
##           master    #1822      +/-   ##
==========================================
- Coverage    30.9%   30.57%   -0.33%     
==========================================
  Files         140      140              
  Lines       13608    13723     +115     
==========================================
- Hits         4205     4196       -9     
- Misses       8961     9086     +125     
+ Partials      442      441       -1
Impacted Files Coverage Δ
api/models/app.go 14.59% <ø> (ø)
provider/aws/builds.go 54.85% <ø> (-0.47%)
cmd/convox/convox.go 100% <ø> (ø)
cmd/convox/doctor.go 0.87% <ø> (-0.01%)
provider/aws/releases.go 49.34% <ø> (ø)
api/controllers/builds.go 4.69% <ø> (-1.04%)
api/models/release.go 0% <ø> (ø)
api/controllers/releases.go 7.05% <ø> (-1.77%)
api/controllers/routes.go 100% <100%> (ø)
api/controllers/apps.go 39.74% <100%> (+2.24%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf0228...41971c8. Read the comment docs.

Copy link
Contributor

@nzoschke nzoschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Doing a bit of testing around build/release notifications.

@MiguelMoll MiguelMoll merged commit dad694c into master Feb 8, 2017
@MiguelMoll MiguelMoll deleted the 20170208 branch February 8, 2017 22:26
SonOfBytes pushed a commit to SonOfBytes/rack that referenced this pull request Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants