Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dedicated installs by using Tenancy param instead of hard coding "default" #2026

Merged
merged 1 commit into from Mar 9, 2017

Conversation

mattmanning
Copy link
Contributor

@mattmanning mattmanning commented Mar 7, 2017

Follow up to #1963 after shipping the needed permissions in a required release (https://github.com/convox/rack/releases/tag/20170306140228)

Addresses #1933

@codecov
Copy link

codecov bot commented Mar 7, 2017

Codecov Report

Merging #2026 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2026      +/-   ##
==========================================
- Coverage   30.53%   30.52%   -0.01%     
==========================================
  Files         143      143              
  Lines       14242    14242              
==========================================
- Hits         4349     4348       -1     
- Misses       9448     9449       +1     
  Partials      445      445
Impacted Files Coverage Δ
api/models/cronjob.go 82.75% <0%> (-3.45%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74da5ee...de79905. Read the comment docs.

@mattmanning mattmanning added this to the 20170307 milestone Mar 7, 2017
mattmanning added a commit that referenced this pull request Mar 7, 2017
@mattmanning mattmanning merged commit de79905 into master Mar 9, 2017
SonOfBytes pushed a commit to SonOfBytes/rack that referenced this pull request Mar 17, 2017
@ddollar ddollar deleted the dedicated-tenancy branch March 29, 2017 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants