Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop trailing slash from api get and delete args #2078

Closed
wants to merge 2 commits into from

Conversation

soulshake
Copy link
Contributor

@soulshake soulshake commented Mar 20, 2017

Dumbest, tiniest PR ever, but i keep typoing it and it bugs me. (Feel free to reject.)

Before:

$ /usr/local/bin/convox api get /apps/
ERROR: response status: 404 404 page not found

After:

$ convox api get /apps/
[
  {
    "name": "cv-soulshake-net",
    "release": "RRANZYKRPSM",
    "status": "running"
  },
  {
    "name": "trainingwheels",
    "release": "",
    "status": "running"
  }
]

@codecov
Copy link

codecov bot commented Mar 20, 2017

Codecov Report

Merging #2078 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2078      +/-   ##
==========================================
+ Coverage    30.7%   30.73%   +0.02%     
==========================================
  Files         143      143              
  Lines       14342    14344       +2     
==========================================
+ Hits         4404     4408       +4     
+ Misses       9482     9481       -1     
+ Partials      456      455       -1
Impacted Files Coverage Δ
cmd/convox/api.go 39.34% <0%> (-1.34%) ⬇️
cmd/convox/stdcli/stdcli.go 38.77% <0%> (+1.53%) ⬆️
api/models/cronjob.go 86.2% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f18ad...6574f16. Read the comment docs.

@soulshake
Copy link
Contributor Author

@soulshake
Copy link
Contributor Author

@@ -275,3 +275,22 @@ func TestApiGetNoArg(t *testing.T) {
},
)
}

// TestApiGet404 should ensure an error is returned when a user runs 'convox api get' with an invalid API endpoint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should read TestApiTrailingSlash and a different comment of what it's really testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks

@MiguelMoll MiguelMoll added this to the 20170323 milestone Mar 23, 2017
MiguelMoll pushed a commit that referenced this pull request Mar 23, 2017
@MiguelMoll MiguelMoll mentioned this pull request Mar 23, 2017
18 tasks
MiguelMoll pushed a commit that referenced this pull request Mar 23, 2017
MiguelMoll pushed a commit that referenced this pull request Mar 24, 2017
MiguelMoll pushed a commit that referenced this pull request Mar 24, 2017
@MiguelMoll MiguelMoll deleted the api-drop-trailing-slash branch March 28, 2017 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants