New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop trailing slash from api get and delete args #2078
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2078 +/- ##
==========================================
+ Coverage 30.7% 30.73% +0.02%
==========================================
Files 143 143
Lines 14342 14344 +2
==========================================
+ Hits 4404 4408 +4
+ Misses 9482 9481 -1
+ Partials 456 455 -1
Continue to review full report at Codecov.
|
9b88cf7
to
e4caba8
Compare
cmd/convox/api_test.go
Outdated
@@ -275,3 +275,22 @@ func TestApiGetNoArg(t *testing.T) { | |||
}, | |||
) | |||
} | |||
|
|||
// TestApiGet404 should ensure an error is returned when a user runs 'convox api get' with an invalid API endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should read TestApiTrailingSlash
and a different comment of what it's really testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, thanks
cddb447
to
fdcb528
Compare
fdcb528
to
6574f16
Compare
Dumbest, tiniest PR ever, but i keep typoing it and it bugs me. (Feel free to reject.)
Before:
After: