Add rack instance security group param #2271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2271 +/- ##
=======================================
Coverage 29.19% 29.19%
=======================================
Files 144 144
Lines 18765 18765
=======================================
Hits 5478 5478
Misses 12810 12810
Partials 477 477Continue to review full report at Codecov.
|
|
@william-richard Could you rebase on master so we could move this PR forward. Thanks! |
william-richard
force-pushed
the
add-rack-instance-security-group-param
branch
from
caecb0d
to
91e292e
Compare
|
Hi @MiguelMoll - I just rebased. Let me know if there's anything else I can do 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to start using convox, but would like to have tight control over the security groups of the ecs instances. This change allows you to override the default security group, with one managed outside of convox's stack.
I have tested it with one of our internal apps - the only issue I ran into is you need to explicitly allow traffic from the convox app within the security group. As long as you have those rules, it works well.