-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read aws credentials from STDIN #26
Conversation
mind adding a few tests around this one? i've added a couple of other examples of cli tests for other commands |
i thought you'd never ask :) |
so testing this isn't super straightforward. a call to install makes multiple network requests to four different hosts:
so far i've repurposed some of the controller test code to mock out the interaction w. aws. stubbing out the new kernel should follow the pattern of some of the other tests. still not sure what i want to do with S3 and mixpanel. i'm tempted to just let the S3 one hit the network but don't want to do that for mixpanel. thoughts welcome. |
0f424a4
to
3d35336
Compare
I would probably stub out the version-getter and mixpanel. You can create a VersionChecker variable that normally is the object from |
3d35336
to
94411a7
Compare
stackId := "arn:aws:cloudformation:us-east-1:123456789:stack/MyStack/aaf549a0-a413-11df-adb3-5081b3858e83" | ||
cycles := []awsutil.Cycle{ | ||
awsutil.Cycle{ | ||
awsutil.Request{"/", "", "/./"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have to update this to check what we put in
Use pointers to return credentials so you can nil them |
even if i pass in a version, we make network requests. this is ready to merge |
👍 |
read aws credentials from STDIN
fixes #19
works like:
aws sts get-session-token | convox install