Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use an existing certificate for services if available #2673

Closed
wants to merge 4 commits into from

Conversation

ddollar
Copy link
Contributor

@ddollar ddollar commented May 17, 2018

if a certificate already exists that matches all of the domains for a service, use it instead of creating a new one

@ddollar ddollar added this to the 20180518 milestone May 18, 2018
ddollar added a commit that referenced this pull request May 18, 2018
@ddollar ddollar mentioned this pull request May 18, 2018
15 tasks
@ddollar ddollar deleted the existing-certificate branch May 21, 2018 01:38
@ndbroadbent
Copy link

ndbroadbent commented May 29, 2018

I'm still seeing a request for a duplicate certificate in AWS Certificate Manager. My rack version is: 20180524143822.

My convox.yml is like this:

services:
  web:
    domain:
      - subdomain.example.com

The first request sent verification emails to postmaster@subdomain.example.com, administrator@subdomain.example.com, etc.

On my next deploy, it created another certificate for the same domain, with a status of Pending validation. But it sent out the verification emails to different addresses: postmaster@example.com, administrator@example.com, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants