Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pagination in describeRackStacks #2733

Closed

Conversation

thieman
Copy link
Contributor

@thieman thieman commented Jun 18, 2018

We're hitting a bug where convox uninstall is returning the following error message to us:

ERROR: can not find rack named (our rack name)
Are you authenticating with the correct AWS account?
See AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, and ~/.aws/credentials

Pretty sure my credentials are fine as I just used the same command and credentials to successfully uninstall a different rack in our account.

I think what's happening here is we're using DescribeStacks directly but making no effort to consume multiple pages of information. I suspect the rack in question is not included in the first page of results and causes our error. This PR moves us from using DescribeStacks directly to instead use DescribeStacksPages which handles consuming the pages for us.

One note: I think the scoping of apps, rack, and resources is fine but I'm a bit nervous about them as I've been bitten by scoping before. This function also does not seem to be covered directly by any tests (though something calling it may be, I'm not sure).

We've had this problem before: #1385. It may be worth a wider audit of our DescribeStacks usage.

@thieman thieman force-pushed the tnt/describe-rack-stacks-paginate branch from 8b3e37b to b17481a Compare June 18, 2018 20:12
@thieman thieman force-pushed the tnt/describe-rack-stacks-paginate branch from b17481a to a538734 Compare June 18, 2018 20:12
@ddollar
Copy link
Contributor

ddollar commented Jun 23, 2018

This will be handled by the CLI change coming in #2739

@ddollar ddollar closed this Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants