Support pagination in describeRackStacks #2733
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're hitting a bug where
convox uninstall
is returning the following error message to us:Pretty sure my credentials are fine as I just used the same command and credentials to successfully uninstall a different rack in our account.
I think what's happening here is we're using
DescribeStacks
directly but making no effort to consume multiple pages of information. I suspect the rack in question is not included in the first page of results and causes our error. This PR moves us from usingDescribeStacks
directly to instead useDescribeStacksPages
which handles consuming the pages for us.One note: I think the scoping of
apps
,rack
, andresources
is fine but I'm a bit nervous about them as I've been bitten by scoping before. This function also does not seem to be covered directly by any tests (though something calling it may be, I'm not sure).We've had this problem before: #1385. It may be worth a wider audit of our
DescribeStacks
usage.