Restrict ApiPolicy acess #3645
Closed
Restrict ApiPolicy acess #3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 35.98% // Head: 35.98% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #3645 +/- ##
=======================================
Coverage 35.98% 35.98%
=======================================
Files 168 168
Lines 18585 18585
=======================================
Hits 6687 6687
Misses 10759 10759
Partials 1139 1139 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nightfury1204
approved these changes
Feb 28, 2023
Twsouza
added a commit
that referenced
this pull request
Feb 28, 2023
### What is the feature/fix? ApiPolicy and ApiRole are used by the rack api to create the services (and resources such as services roles and their assignments). The policy scope should be restricted to convox resources. ### Does it has a breaking change? No. ### How to use/test it? Update/Create the rack on version `20230222192752-chore-873-apipolicy-permission`, and deploy a new app. ### Checklist - [ ] New coverage tests - [x] Unit tests passing - [x] E2E tests passing - [x] E2E downgrade/update test passing - [ ] Documentation updated - [x] No warnings or errors on Deepsource/Codecov
Twsouza
added a commit
that referenced
this pull request
Mar 2, 2023
### What is the feature/fix? ApiPolicy and ApiRole are used by the rack api to create the services (and resources such as services roles and their assignments). The policy scope should be restricted to convox resources. ### Does it has a breaking change? No. ### How to use/test it? Update/Create the rack on version `20230222192752-chore-873-apipolicy-permission`, and deploy a new app. ### Checklist - [ ] New coverage tests - [x] Unit tests passing - [x] E2E tests passing - [x] E2E downgrade/update test passing - [ ] Documentation updated - [x] No warnings or errors on Deepsource/Codecov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
ApiPolicy and ApiRole are used by the rack api to create the services (and resources such as services roles and their assignments). The policy scope should be restricted to convox resources.
Does it has a breaking change?
No.
How to use/test it?
Update/Create the rack on version
20230222192752-chore-873-apipolicy-permission, and deploy a new app.Checklist