Use SSM Parameter store to keep the API Password on task definition #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3654 +/- ##
=======================================
Coverage 36.01% 36.01%
=======================================
Files 168 168
Lines 18585 18585
=======================================
Hits 6694 6694
Misses 10751 10751
Partials 1140 1140 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
yuriadams
approved these changes
Mar 21, 2023
Twsouza
added a commit
that referenced
this pull request
Mar 21, 2023
…nition ### What is the feature/fix? Instead of passing the API password to the rack as plain text, it will store the password on SSM Parameter Store and then pass it as a secret to the task definition. AWS charges to keep and use the Secret Manager, it would increase the user cost to store the password, the SSM is a cheaper alternative. ### Does it has a breaking change? No ### How to use/test it? Update/create a rack using the RC, then use it normally, it should not interfere in the user experience. ### Checklist - [ ] New coverage tests - [x] Unit tests passing - [x] E2E tests passing - [x] E2E downgrade/update test passing - [ ] Documentation updated - [x] No warnings or errors on Deepsource/Codecov
Twsouza
added a commit
that referenced
this pull request
Mar 22, 2023
…nition ### What is the feature/fix? Instead of passing the API password to the rack as plain text, it will store the password on SSM Parameter Store and then pass it as a secret to the task definition. AWS charges to keep and use the Secret Manager, it would increase the user cost to store the password, the SSM is a cheaper alternative. ### Does it has a breaking change? No ### How to use/test it? Update/create a rack using the RC, then use it normally, it should not interfere in the user experience. ### Checklist - [ ] New coverage tests - [x] Unit tests passing - [x] E2E tests passing - [x] E2E downgrade/update test passing - [ ] Documentation updated - [x] No warnings or errors on Deepsource/Codecov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
Instead of passing the API password to the rack as plain text, it will store the password on SSM Parameter Store and then pass it as a secret to the task definition.
AWS charges to keep and use the Secret Manager, it would increase the user cost to store the password, the SSM is a cheaper alternative.
Does it has a breaking change?
No
How to use/test it?
Update/create a rack using the RC, then use it normally, it should not interfere in the user experience.
Checklist