Store rack install & rack update telemetry data (V2) #3668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuriadams
added a commit
that referenced
this pull request
May 1, 2023
### What is the feature/fix?  ### Add screenshot or video (optional) Doc: https://convox602-my.sharepoint.com/:w:/g/personal/yuri_adams_convox_com/ERKCC87MHOxLi6_3F8PqWqIBOWecg2nEg06tIbl9NA6ujQ?e=8bW5AX ### Does it has a breaking change? No
Twsouza
previously approved these changes
May 2, 2023
yuriadams
added a commit
that referenced
this pull request
May 3, 2023
### What is the feature/fix?  ### Add screenshot or video (optional) Doc: https://convox602-my.sharepoint.com/:w:/g/personal/yuri_adams_convox_com/ERKCC87MHOxLi6_3F8PqWqIBOWecg2nEg06tIbl9NA6ujQ?e=8bW5AX ### Does it has a breaking change? No
yuriadams
added a commit
that referenced
this pull request
May 3, 2023
### What is the feature/fix?  ### Add screenshot or video (optional) Doc: https://convox602-my.sharepoint.com/:w:/g/personal/yuri_adams_convox_com/ERKCC87MHOxLi6_3F8PqWqIBOWecg2nEg06tIbl9NA6ujQ?e=8bW5AX ### Does it has a breaking change? No
yuriadams
added a commit
that referenced
this pull request
May 3, 2023
### What is the feature/fix?  ### Add screenshot or video (optional) Doc: https://convox602-my.sharepoint.com/:w:/g/personal/yuri_adams_convox_com/ERKCC87MHOxLi6_3F8PqWqIBOWecg2nEg06tIbl9NA6ujQ?e=8bW5AX ### Does it has a breaking change? No
yuriadams
added a commit
that referenced
this pull request
May 3, 2023
### What is the feature/fix?  ### Add screenshot or video (optional) Doc: https://convox602-my.sharepoint.com/:w:/g/personal/yuri_adams_convox_com/ERKCC87MHOxLi6_3F8PqWqIBOWecg2nEg06tIbl9NA6ujQ?e=8bW5AX ### Does it has a breaking change? No
yuriadams
added a commit
that referenced
this pull request
May 3, 2023
### What is the feature/fix?  ### Add screenshot or video (optional) Doc: https://convox602-my.sharepoint.com/:w:/g/personal/yuri_adams_convox_com/ERKCC87MHOxLi6_3F8PqWqIBOWecg2nEg06tIbl9NA6ujQ?e=8bW5AX ### Does it has a breaking change? No
Twsouza
suggested changes
May 8, 2023
Comment on lines
+25
to
+27
| "ApiCount", | ||
| "ApiCpu", | ||
| "ApiMonitorMemory", |
There was a problem hiding this comment.
I don't think we should redacted this, it's a simple parameter and it doesn't contain any sensitive information.
| "Version", | ||
| }, ",") | ||
|
|
||
| redactedParams = strings.Join([]string{ |
There was a problem hiding this comment.
imho, the following parameters should not be redacted:
ApiRouter
ApiWebMemory
Autoscale
AvailabilityZones
BuildCpu
BuildImage
BuildInstance
BuildMemory
BuildVolumeSize
Development
EcsPollInterval
EncryptEbs
Encryption
HighAvailability
ImagePullBehavior
IMDSHttpTokens
Internal
InternalOnly
InstanceType
InstanceUpdateBatchSize
LogDriver
LogRetention
Private
PrivateApi
PrivateApiSecurityGroup
PrivateBuild
ScheduleRackScaleDown
ScheduleRackScaleUp
SpotInstanceBid
Subnet0CIDR
Subnet1CIDR
Subnet2CIDR
SubnetPrivate0CIDR
SubnetPrivate1CIDR
SubnetPrivate2CIDR
SwapSize
SyslogFormat
VPCCIDR
Tenancy
They don't have sensitive information and will be helpful for telemetry.
There was a problem hiding this comment.
although they are string, they are a list of values or just numbers.
yuriadams
added a commit
that referenced
this pull request
May 9, 2023
### What is the feature/fix?  ### Add screenshot or video (optional) Doc: https://convox602-my.sharepoint.com/:w:/g/personal/yuri_adams_convox_com/ERKCC87MHOxLi6_3F8PqWqIBOWecg2nEg06tIbl9NA6ujQ?e=8bW5AX ### Does it has a breaking change? No
yuriadams
added a commit
that referenced
this pull request
May 9, 2023
### What is the feature/fix?  ### Add screenshot or video (optional) Doc: https://convox602-my.sharepoint.com/:w:/g/personal/yuri_adams_convox_com/ERKCC87MHOxLi6_3F8PqWqIBOWecg2nEg06tIbl9NA6ujQ?e=8bW5AX ### Does it has a breaking change? No
yuriadams
added a commit
that referenced
this pull request
May 9, 2023
### What is the feature/fix?  ### Add screenshot or video (optional) Doc: https://convox602-my.sharepoint.com/:w:/g/personal/yuri_adams_convox_com/ERKCC87MHOxLi6_3F8PqWqIBOWecg2nEg06tIbl9NA6ujQ?e=8bW5AX ### Does it has a breaking change? No
yuriadams
added a commit
that referenced
this pull request
May 10, 2023
### What is the feature/fix?  ### Add screenshot or video (optional) Doc: https://convox602-my.sharepoint.com/:w:/g/personal/yuri_adams_convox_com/ERKCC87MHOxLi6_3F8PqWqIBOWecg2nEg06tIbl9NA6ujQ?e=8bW5AX ### Does it has a breaking change? No
yuriadams
added a commit
that referenced
this pull request
May 10, 2023
### What is the feature/fix?  ### Add screenshot or video (optional) Doc: https://convox602-my.sharepoint.com/:w:/g/personal/yuri_adams_convox_com/ERKCC87MHOxLi6_3F8PqWqIBOWecg2nEg06tIbl9NA6ujQ?e=8bW5AX ### Does it has a breaking change? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
Add screenshot or video (optional)
Doc: https://convox602-my.sharepoint.com/:w:/g/personal/yuri_adams_convox_com/ERKCC87MHOxLi6_3F8PqWqIBOWecg2nEg06tIbl9NA6ujQ?e=8bW5AX
Does it has a breaking change?
No