Fix Spot instances preventing rack from updating #3685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3685 +/- ##
=======================================
Coverage 35.78% 35.78%
=======================================
Files 169 169
Lines 18719 18719
=======================================
Hits 6699 6699
Misses 10882 10882
Partials 1138 1138 ☔ View full report in Codecov by Sentry. |
nightfury1204
approved these changes
Jun 19, 2023
nightfury1204
added a commit
that referenced
this pull request
Jun 19, 2023
### What is the feature/fix? Add missing commands from launch config to launch template and use spot lifecycle. ### Does it has a breaking change? No, fix rack update when spot instance bid is set. ### How to use/test it? - Install a rack on [20230427130715](https://github.com/convox/rack/releases/tag/20230427130715). - Create and deploy an app. - Scale the app (e.g. `convox scale SERVICENAME --count=20`) - Then try to install the RC (creating**) ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
4 tasks
nightfury1204
added a commit
that referenced
this pull request
Jun 19, 2023
### What is the feature/fix? Add missing commands from launch config to launch template and use spot lifecycle. ### Does it has a breaking change? No, fix rack update when spot instance bid is set. ### How to use/test it? - Install a rack on [20230427130715](https://github.com/convox/rack/releases/tag/20230427130715). - Create and deploy an app. - Scale the app (e.g. `convox scale SERVICENAME --count=20`) - Then try to install the RC (creating**) ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
Add missing commands from launch config to launch template and use spot lifecycle.
Does it has a breaking change?
No, fix rack update when spot instance bid is set.
How to use/test it?
convox scale SERVICENAME --count=20)Checklist