Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple certs from ssl #568

Merged
merged 7 commits into from Apr 25, 2016
Merged

decouple certs from ssl #568

merged 7 commits into from Apr 25, 2016

Conversation

ddollar
Copy link
Contributor

@ddollar ddollar commented Apr 21, 2016

  • Adds convox certs create <pub> <key> [--chain <chain>]
  • Adds convox certs to list certificates associated with the account
  • Adds convox certs delete <id> to delete a certificate
  • Adds convox certs generate <domain> to generate an ACM certificate
  • SSL update is now convox ssl update <process:port> <certificate>

See Also

Release Playbook

  • Rebase against master
  • Release branch ()
  • Pass CI ()
  • Code review
  • Merge into master
  • Release master ()
  • Pass CI ()
  • Update staging rack
  • Edit Rack release record and/or update docs
  • Publish release
  • Release CLI

@mattmanning
Copy link
Contributor

mattmanning commented Apr 21, 2016

👍 This is fantastic. Decoupling cert management is totally the right thing to do at this stage and I'm excited we can avoid uploading the same cert multiple times now.

What do you think about convox ssl update <process:port> --generate to create and update an ACM cert? Not suggesting we take away the convox certs generate command, just as a shorthand command to do both.

@ddollar
Copy link
Contributor Author

ddollar commented Apr 21, 2016

ACM cert generation is a two-step process that involves receiving an email and clicking a link. The ACM cert isn't valid until you do that.

$ convox ssl update web:443 acm-6a4a10d62b4a -a sinatra
Updating certificate... ERROR: acm-6a4a10d62b4a is still pending validation

@ddollar
Copy link
Contributor Author

ddollar commented Apr 21, 2016

certificate updates

@awsmsrc awsmsrc mentioned this pull request Apr 21, 2016
9 tasks
@nzoschke nzoschke mentioned this pull request Apr 25, 2016
11 tasks
@nzoschke nzoschke merged commit 5442559 into master Apr 25, 2016
@ddollar ddollar deleted the certs branch April 29, 2016 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants