Fix/selenium race conditions #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarranz
force-pushed
the
fix/selenium-race-conditions
branch
from
c07b6ac
to
887e915
Compare
fdelavega
reviewed
Jul 13, 2018
aarranz
force-pushed
the
fix/selenium-race-conditions
branch
3 times, most recently
from
b224788
to
94db176
Compare
aarranz
force-pushed
the
fix/selenium-race-conditions
branch
from
94db176
to
fd5c692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code has some race conditions on the selenium tests, making those tests randomly fail. This PR request fixes this by removing the use of the
implicitly_waitmethod (directly discouraged by Selenium) and adding the required explicit waits.