Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ngsi registry #3

Merged
merged 16 commits into from
Jul 17, 2018
Merged

Feature/ngsi registry #3

merged 16 commits into from
Jul 17, 2018

Conversation

fdelavega
Copy link

No description provided.

@fdelavega fdelavega requested a review from aarranz July 16, 2018 16:48
@coveralls
Copy link

coveralls commented Jul 17, 2018 •
edited

Pull Request Test Coverage Report for Build 58

  • 152 of 167 (91.02%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+9.8%) to 82.682%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ckanext/ngsiview/plugin.py 53 57 92.98%
ckanext/ngsiview/controller.py 46 57 80.7%
Totals Coverage Status
Change from base Build 32: 9.8%
Covered Lines: 296
Relevant Lines: 358
💛 - Coveralls

@fdelavega fdelavega force-pushed the feature/ngsi-registry branch 3 times, most recently from a6cd4ce to 4abc6f1 Compare July 17, 2018 11:02
@fdelavega fdelavega force-pushed the feature/ngsi-registry branch 2 times, most recently from 832df6f to 5f2a9d8 Compare July 17, 2018 11:37
@fdelavega fdelavega force-pushed the feature/ngsi-registry branch 7 times, most recently from 107eac4 to a9ad841 Compare July 17, 2018 13:42
@fdelavega fdelavega force-pushed the feature/ngsi-registry branch 2 times, most recently from 734af01 to 4467b23 Compare July 17, 2018 13:56
aarranz
aarranz approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@aarranz aarranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarranz aarranz merged commit a810f25 into master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarranz aarranz aarranz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fdelavega @coveralls @aarranz