Spelling #243
Spelling #243
Conversation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
|
Hello there!👋 Welcome to the project!💖 Thank you and congrats🎉 for opening your first pull request✨ 🙌.We will get back to you as soon as we can.😄 |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vscode-github1s/github1s/255uTtJ8g4aroEVZTxC5iGgvNfPg |
| <img height="500px" src="https://raw.githubusercontent.com/timbaileyjones/github1s/master/resources/images/auth-token.png" /> | ||
| <img height="500px" src="https://raw.githubusercontent.com/conwnet/github1s/master/resources/images/auth-token.png" /> | ||
|
|
||
| ## Screenshots | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
This changes the images to rely on the canonical repository location.
It's also changing the filename to match the brand (this can potentially cause problems for Windows users as case changes for files can be messy).
| @@ -136,22 +136,22 @@ The continued development and maintenance of GitHub1s is made possible by these | |||
|
|
|||
| - [febaoshan/edge-extensions-github-code-viewer](https://github.com/febaoshan/edge-extensions-github-code-viewer) - [Chrome Web Store](https://chrome.google.com/webstore/detail/github-code-viewer/ecddapgifccgblebfibdgkagfbdagjfn) | |||
|
|
|||
| - [Darkempire78/Github1s-Extension](https://github.com/Darkempire78/Github1s-Extension) | |||
| - [zvizvi/Github Web IDE](https://github.com/zvizvi/github-web-ide) - [Chrome Web Store](https://chrome.google.com/webstore/detail/adjiklnjodbiaioggfpbpkhbfcnhgkfe) | |||
| - [Darkempire78/GitHub1s-Extension](https://github.com/Darkempire78/GitHub1s-Extension) | |||
There was a problem hiding this comment.
GitHub repository names are case preserving, but not case sensitive, so this can be done even if @Darkempire78 doesn't rename their repository.
| - [Darkempire78/Github1s-Extension](https://github.com/Darkempire78/Github1s-Extension) | ||
| - [zvizvi/Github Web IDE](https://github.com/zvizvi/github-web-ide) - [Chrome Web Store](https://chrome.google.com/webstore/detail/adjiklnjodbiaioggfpbpkhbfcnhgkfe) | ||
| - [Darkempire78/GitHub1s-Extension](https://github.com/Darkempire78/GitHub1s-Extension) | ||
| - [zvizvi/GitHub Web IDE](https://github.com/zvizvi/github-web-ide) - [Chrome Web Store](https://chrome.google.com/webstore/detail/adjiklnjodbiaioggfpbpkhbfcnhgkfe) |
There was a problem hiding this comment.
Similarly, @zvizvi can safely adjust the title of their tool (although sometimes using someone else's brand is problematic)...
| @@ -89,7 +89,7 @@ export const validateToken = (token: string) => { | |||
| // [List matching references](https://docs.github.com/en/rest/reference/git#list-matching-references) | |||
| // can returned all branches for a request, and there is an issue for this API | |||
| // https://github.com/github/docs/issues/3863 | |||
| export const getGithubBranchRefs = (owner: string, repo: string) => { | |||
| export const getGitHubBranchRefs = (owner: string, repo: string) => { | |||
There was a problem hiding this comment.
It isn't a big deal for me to drop changes to things (usually by commit = word, but also by file path).
| getGitHubBranchRefs, | ||
| getGitHubPullDetail, | ||
| getGithubTagRefs, |
There was a problem hiding this comment.
The inconsistencies here argue in favor of this change
| @@ -348,7 +348,7 @@ export class ActivitybarPart extends Part implements IActivityBarService { | |||
| actions.push( | |||
| new Action( | |||
| ToggleActivityBarVisibilityAction.ID, | |||
| nls.localize('hideActivitBar', 'Hide Activity Bar'), | |||
| nls.localize('hideActivityBar', 'Hide Activity Bar'), | |||
There was a problem hiding this comment.
Typos in localizable strings often lead to poor translations
| @@ -64,13 +64,13 @@ export const insertGitHubRESTEntryToDirectory = ( | |||
| }; | |||
|
|
|||
| /** | |||
| * This funtion must be used for only GraphQL output | |||
| * This function must be used for only GraphQL output | |||
|
LGTM! Thank you so much! |
|
Congrats on merging your first pull request! 🎉🎉🎉 We here at github1s are proud of you! |
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/check-spelling/github1s/commit/ae6eb906c8340ee85b53e34a8cbf59efd6853471#commitcomment-48585842
The action reports that the changes in this PR would make it happy: https://github.com/check-spelling/github1s/commit/890e059a5635f2df7f09c577a7f8b6e2338f11da