Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the OSSInsight API to public endpoint #524

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Migrate the OSSInsight API to public endpoint #524

merged 1 commit into from
Oct 23, 2023

Conversation

conwnet
Copy link
Owner

@conwnet conwnet commented Sep 19, 2023

This PR resolves #522

@vercel
Copy link

vercel bot commented Sep 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
github1s ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2023 8:01pm

@conwnet conwnet marked this pull request as draft September 19, 2023 18:28
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Mini256
Mini256 reviewed Oct 9, 2023
View reviewed changes
Copy link

@Mini256 Mini256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any problem hinder the migration process? Is there anything I can help with.

I tried it out in the preview environment and found that:

  • Need to using TypeScript instead of Typescript: https://api.ossinsight.io/v1/trends/repos/?language=TypeScript&period=past_week
  • Collections Page seems broken in the preview

@conwnet
Copy link
Owner Author

conwnet commented Oct 17, 2023

@Mini256 Thank you so much for pointing out the problem. I have already fixed it.

Is there a way to get all the Collections in the new Public API? I'm still using the old API here, Is there any plan to remove this Collections API?

https://api.ossinsight.io/collections

@Mini256
Copy link

Mini256 commented Oct 20, 2023

@conwnet Yes, we have added a new API: https://ossinsight.io/docs/api/list-collections/

@conwnet conwnet marked this pull request as ready for review October 22, 2023 19:57
Siddhant-K-code
Siddhant-K-code approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 🎉

@conwnet conwnet merged commit 9b26e29 into master Oct 23, 2023
15 checks passed
@conwnet conwnet deleted the ossinsight branch October 23, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mini256 Mini256 Mini256 left review comments

@Siddhant-K-code Siddhant-K-code Siddhant-K-code approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate the OSSInsight API to public endpoint
3 participants
@conwnet @Mini256 @Siddhant-K-code