Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting margins (insets) for watermarks #177

Open
rider87 opened this issue Sep 21, 2021 · 4 comments
Open

Allow setting margins (insets) for watermarks #177

rider87 opened this issue Sep 21, 2021 · 4 comments

Comments

@rider87
Copy link

rider87 commented Sep 21, 2021

Hi all,

Is there a possibility to have margin for the watermark?
Like you maybe know from Lightroom?

Please see this example... There is a space between bottom and left side...
Is this also possible?

image

@rider87
Copy link
Author

rider87 commented Sep 21, 2021

I believe it´s just to adjust this code:
image

Currently only one value is there...
Can we do margin for

  • top
  • bottom
  • right
  • left

@coobird
Copy link
Owner

coobird commented Sep 21, 2021

Are you asking whether it's possible to have top/bottom/left/right margins to be set independently? If that's the case, as you found in the code, right now that's not possible.

@rider87
Copy link
Author

rider87 commented Sep 21, 2021

yes, correct.... currently I can see to set only one value for all (top/bottom/left/right)...

Can this be implemented?
I believe there needs just to add 3 addtional parameters to the function...

@coobird
Copy link
Owner

coobird commented Nov 23, 2021

I'm hesitant to add yet another overload for the watermark method to the Thumbnailator API, especially one that has 7 arguments. That said, I'll keep this issue open as this sounds like a valid use case.

@coobird coobird changed the title Margin for Watermark? Allow setting margins (insets) for watermarks Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants