Lint fixes, adding docs for all public functions, utilize constants and make looping consistent. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
reviewed
Oct 16, 2018
cache.go
Outdated
| @@ -9,18 +9,24 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| minBufSize = 512 * 1024 | |||
| // segmentSize represents the number of segments within a freecache instance. | |||
| segmentSize = 256 | |||
There was a problem hiding this comment.
I think segmentCount or numSegments is better.
There was a problem hiding this comment.
Sure, I renamed it to segmentCount to be consistent.
|
Nice cleanup, thank you! |
|
@coocood - thank you as well for this library and for the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What a fantastic cache solution you've built. Really liking the design of this cache solution!
I hope this change is welcomed...as it mainly cleans up some minor things that my linter found, makes docs consistent and adds constants.
Please, let me know if anything should be tweaked to your liking.