Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch size optimization can be applied by `ListingConfig.ORG_HIBERNAT… #15

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

laugen
Copy link
Member

@laugen laugen commented Mar 28, 2020

…E_FETCHSIZE, witch will add typedQuery.setHint("org.hibernate.fetchSize", ListingConfig.ORG_HIBERNATE_FETCHSIZE);` to the query if set.

…E_FETCHSIZE`, witch will add `typedQuery.setHint("org.hibernate.fetchSize", ListingConfig.ORG_HIBERNATE_FETCHSIZE);` to the query if set.
CHANGELOG.md Outdated
@@ -14,6 +14,7 @@

* Visual table summary? Want to know what's the most of something? No problem! You can acquire terms and statistics by just throwing attribute names into filter! Have a look at *Visual Table Summary* in this [UX Collective article](https://uxdesign.cc/design-better-data-tables-4ecc99d23356).
* TO FUCKING DO!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete me...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

der pull reqeust geht ja nur in den 1.6.0-SNAPSHOT branch, da fehlt noch doku...

* You can also set this globally by adding <code>&lt;property name="hibernate.jdbc.fetch_size" value="100"/&gt; </code> to your options in
* <code>persitence.xml</code>
*/
public static int ORG_HIBERNATE_FETCHSIZE = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich glaub ich würde hier das Ding einfach nur FETCHSIZE nennen, den unter umständen wechselt die Implementierung drunter. Zum Beispiel via Eclipselink...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hatte ich auch gedacht, aber wieder vergessen

Copy link
Member

@JPM84 JPM84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@laugen laugen merged commit 1e47020 into 1.6.0-SNAPSHOT Mar 30, 2020
@laugen laugen deleted the org.hibernate.fetchSize branch March 30, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants