Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ServiceWorker to allow offline #23

Closed
coogie opened this issue Sep 26, 2019 · 5 comments
Closed

Add ServiceWorker to allow offline #23

coogie opened this issue Sep 26, 2019 · 5 comments
Assignees
@vitokhangnguyen
Labels
1 - Ready CLAIMED enhancement good first issue Hacktoberfest

Comments

@coogie
Copy link
Owner

coogie commented Sep 26, 2019

Once the migration to HTTPS happens, a Service Worker should be added to the site to allow it to function offline.

For reasons...
@vitokhangnguyen
Copy link
Contributor

This is a very cool idea and I do not see why this app should need an internet connection.
I would like to work on this issue!

@coogie coogie assigned coogie and vitokhangnguyen and unassigned coogie Sep 26, 2019
@coogie coogie added the CLAIMED label Sep 26, 2019
@coogie
Copy link
Owner Author

coogie commented Sep 26, 2019

@vitokhangnguyen Have fun!

@vitokhangnguyen
Copy link
Contributor

Hi,
I have successfully made the app work offline and installable. I also added a tool to handle Google Tag Manager when the app's offline.
I would like to wait for a few more days before making a PR so it would be count in Hacktoberfest.

@coogie
Copy link
Owner Author

coogie commented Sep 30, 2019

Hi @vitokhangnguyen

That's fine :)
Just a quick heads up that the site has been migrated to Jekyll today, and this might impact you. Luckily, there's nothing overly complex with the new setup and is should be just as easy to apply your changes.

If you need any advice, just let me know :)

@vitokhangnguyen
Copy link
Contributor

@coogie

Hi, I did not see your message before making the PR #31
I will look into it and add commits to try to get my part work with Jekyll.

coogie pushed a commit that referenced this issue Oct 1, 2019
@vitokhangnguyen @coogie
Fixed issue #23: Service Worker added (#31)
396299c 
* add service worker and manifest

* add icons

* move service worker to root

* move pwa icons to a folder

* Move SW registration outside main.js and cache home root

* simplify SW fetch event handler

* update colorful icons

* Add mobile theme color

* remove pwa files from cached staticAssets

* switch from absolute to relative paths

* adjust start_url

* adjust paths to absolute

* remove arrow notation and async/await in index.html. And relocate icons
@coogie coogie closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitokhangnguyen vitokhangnguyen

Labels
1 - Ready CLAIMED enhancement good first issue Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coogie @vitokhangnguyen