Fixed password update handling #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 7, 2021
sloria
previously approved these changes
Sep 8, 2021
|
Thanks! |
|
@sloria Does the workflow run at a specified time (i.e. nightly) or is there something that I still need to do in order to trigger the checks? |
|
All set! |
auto-merge was automatically disabled
September 9, 2021 00:30
Head branch was pushed to by a user without write access
|
@sloria missing docstring added to fix flake8 error during build |
jamescurtin
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted password field to a hybrid_property, so that when the field is set or updated it is automatically encrypted utilizing
bcrypt. This approach also eliminates the need for an extra step (i.e. calling.set_password) during account creation/updateCloses #158