Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/test_forms.py: fix 'test_validate_success' #1403

Merged
merged 2 commits into from May 11, 2022
Merged

tests/test_forms.py: fix 'test_validate_success' #1403

merged 2 commits into from May 11, 2022

Conversation

AvinashReddy3108
Copy link
Contributor

@AvinashReddy3108 AvinashReddy3108 commented May 11, 2022 •
edited by jamescurtin

Fixes the said test for newer version of the email_validator pip package

Closes #1394

tests/test_forms.py: fix 'test_validate_success'
78d7fa2 
Fixes the said test for newer version of the `email_validator` pip package
@AvinashReddy3108
Copy link
Contributor Author

This "passes" the CI tests for #1397 and #1394 where the workflow is failed with the following error.

FAILED tests/test_forms.py::TestRegisterForm::test_validate_success - assert ...

@AvinashReddy3108
Copy link
Contributor Author

Bumped up requirements to match the dependabot PRs, the CI should pass.

jamescurtin
jamescurtin approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@jamescurtin jamescurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@jamescurtin jamescurtin merged commit c191198 into cookiecutter-flask:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescurtin jamescurtin jamescurtin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AvinashReddy3108 @jamescurtin