Change sentry integration #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browniebroke
reviewed
Oct 1, 2018
{{cookiecutter.project_slug}}/{{cookiecutter.project_slug}}/taskapp/celery.py
Outdated
Show resolved
Hide resolved
msamoylov
reviewed
Oct 9, 2018
There was a problem hiding this comment.
How about https://github.com/pydanny/cookiecutter-django/blob/master/%7B%7Bcookiecutter.project_slug%7D%7D/config/wsgi.py? I think it should be changed as well.
|
@gfabricio mind resolving the merge conflicts? |
|
@gfabricio any news on this one? |
dekoza
reviewed
Dec 20, 2018
dekoza
reviewed
Dec 20, 2018
|
Is anyone using this change in production? Is it ready to use? |
|
This whole section can be removed as well |
|
What about the |
# Conflicts:
# {{cookiecutter.project_slug}}/requirements/production.txt
elyak123
reviewed
Mar 19, 2019
{{cookiecutter.project_slug}}/{{cookiecutter.project_slug}}/taskapp/celery.py
Outdated
Show resolved
Hide resolved
# Conflicts:
# {{cookiecutter.project_slug}}/config/settings/production.py
# {{cookiecutter.project_slug}}/config/wsgi.py
# {{cookiecutter.project_slug}}/{{cookiecutter.project_slug}}/taskapp/celery.py
browniebroke
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1818
A simple screenshot running a django-cookiecutter based test project with the integration using sentry-sdk:
