Only set SERVERS for drf-spectacular in production
#3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is removed from local settings since having the url as 127.0.0.1:8000 triggers a CORS issue when the project runs on localhost:8000. It is kept in production settings as that allows tools that generate code samples to point to the correct domain.
browniebroke
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Looks good to me.
@luzfcb do you want to give this a look before we merge it?
browniebroke
changed the title
SERVERS for drf-spectacular in production only
browniebroke
changed the title
SERVERS for drf-spectacular in production onlySERVERS for drf-spectacular in production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is removed from local settings since having the url as 127.0.0.1:8000 triggers a CORS issue when the project runs on localhost:8000. It is kept in production settings as that allows tools that generate code samples to point to the correct domain.
Description
Checklist:
Rationale
Based on the comments in the issue, I thought it would be good to keep
SERVERSin production settings so the original goal of adding it is met, but also thought it might not be useful in local settings (plus adding it requires settingCORS_ALLOWED_ORIGINS=["localhost:8000"])fixes #3593