Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allauth elements & MFA #4843

Merged
merged 5 commits into from Feb 26, 2024
Merged

Allauth elements & MFA #4843

merged 5 commits into from Feb 26, 2024

Conversation

foarsitter
Copy link
Collaborator

@foarsitter foarsitter commented Feb 8, 2024

This PR implements #4819 and #4691

The design's are very minimalistics but it will be much easier to keep up-to-date with allauth upstream. For example used texts are now the same as allauth uses so we can benefit from their translations.

The way I handle tags isn't the most pretty one but we can address that in another PR.

Fix #4819
Fix #4691

Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed this branch to Heroku: https://browniebrokewny-eaa7f24dd6c4.herokuapp.com/

And the master branch, as baseline: https://browniebrokewnymaster-a0616fed8aca.herokuapp.com/

Looks like a few pages have lost some bits of styling...

@foarsitter foarsitter merged commit daacdd0 into cookiecutter:master Feb 26, 2024
13 checks passed
@foarsitter foarsitter deleted the allauth branch February 26, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allauth template elements Implement django-allauth's MFA
2 participants