Disable UP038 Ruff rule to avoid introducing slower code #5020
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable the UP038 Ruff rule to avoid introducing valid code, which is slower due to the lack of optimization in the Python interpreter itself.
This rule also does not exist in
pyupgrade
for the same reason.Checklist:
Rationale
Although Python 3.10 starts to support the use of Union in
isinstance
andissubclass
, there is a considerable performance loss compared to usingtuple
, which has not yet been fully resolved in the Python interpreter.Python 3.11 has improved performance but is still 4x slower than using tuples. Maybe it will be resolved in Python 3.13.
Check astral-sh/ruff#7871