Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add noqa to ignore ruff false positive #5068

Merged
merged 1 commit into from
May 13, 2024
Merged

Add noqa to ignore ruff false positive #5068

merged 1 commit into from
May 13, 2024

Conversation

browniebroke
Copy link
Member

@browniebroke browniebroke commented May 13, 2024 •
edited

Description

Add missing noqa comment to mark missing import coming from base settings when:

  • frontend_pipeline="Django Compressor"
  • use_whitenoise="y"

Checklist:

  • I've made sure that tests are updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

Fix #4966

@browniebroke browniebroke mentioned this pull request May 13, 2024
Closed
@browniebroke browniebroke changed the title Add noqa to fix ruff error Add noqa to ignore ruff fasle positive May 13, 2024
@browniebroke browniebroke changed the title Add noqa to ignore ruff fasle positive Add noqa to ignore ruff false positive May 13, 2024
@browniebroke browniebroke merged commit e9f029d into cookiecutter:master May 13, 2024
14 checks passed
@browniebroke browniebroke deleted the fix-ruff-error branch May 13, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ruff hook fails with F405 issue in config/settings/production.py
1 participant
@browniebroke