-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cookiecutter template inheritance #409
Comments
Neat idea but I'm closing this issue because:
All this said, it's a fascinating idea. More like this please! 😄 |
I don't have the feeling that you've even read/understood my proposition as 2 of your remarks does not seem to even apply to my proposition (1. - care to be more specific ? and 2. - making a point about the name of this directory is not pertinent, this is an internal convention and does not impose anything in the resulting project generated by cookiecutter). Only point 3 could apply but is a very general statement with no technical value and no objective ground and could be applied to any new or old features... But I feel that current cookiecutter management of community is probably closed enough to my taste (after many PR un-answered for years, closed randomly, with what I perceive as poor technical comments with usually low added value) for me to stop pushing here my code, comments, idea or bugfixes or even trying to argument anything else here. I'm very aware that it won't be a loss at all on your side, that's exactly why I don't feel I should spend more effort here. You have a nice project, I'll probably continue to use it with my added patches... I wish you to achieve your goals with that project ! |
@vaab I am thinking about the same thing, but I've not gotten into implementation details at all yet: https://github.com/ssteinerx/cookiecutter-django-flux |
@vaab Do you still use cookiecutter ? If the patches you mention hereabove are related to template inheritance, are they visible somewhere ? |
@gotcha I sent a few patches on different topics as PR a long time ago, this is what I was referring to in my last message on this thread when I mentionned patches. Unfortunately for you here, I didn't code anything around template inheritance but I'm still using cookie-cutter exclusively with a personal fork with my PRs. If you happen to code anything related to this, please keep me in touch. |
This seems like two separate issues now. One is inheritance which I would absolutely love. Being able to have different project-template for different types of projects that all depend on the same company-wide package-template would be lovely. I think this should be doable without adding in language-specific code. I could see a structure where:
I don't think these additions would result in language-specific features, a significant change in cookiecutters patterns, or a higher skill-floor (it only adds a bit of complexity if you want to use these features) The second issue that @vaab mentions is the need to start the cookie-cutter project with folder that has a templated name. I think while there are valid arguments to be made there we should ignore that requests since it barely has any connection to the name of this issue. @pydanny would you consider opening the issue such that we can discuss the possibility of inheritance in cookiecutter without worrying about the other request? |
I'm highly interested in cookiecutter template inheritance.
It doesn't seems complicated to implement, and I might try it soon.
My first reflection is that it requires to change some core principle, although they are implementable while keeping backward compatibility.
cookiecutter.yml
, adds ainherit
keyword, allowance for multiple inherited valuedoesn't seem difficult to handle:
{{cookiecutter.repo_name}}
or something equivalent. As a user, I might want to specify my target directory name at the CLI level also. Today, the 'repo_name' feels that it should be a command line argument more than queried variable for more than one reason (you don't need to set it per default in your config file for instance).Thank you for your great work on cookiecutter. Don't be offensed by my reflections. And please consider giving me a feedback on how do you feel about these ideas.
The text was updated successfully, but these errors were encountered: